-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html/minifier): merge the same metadata elements #6183
Conversation
We should not merge tags ("style" or other) having some attributes like "id"; but maybe this is a very rare use case. |
We don't merge them when attributes are different, ref - https://github.com/swc-project/swc/pull/6183/files#diff-0b4e64c7085134e2f2ca7f270724e4fd1bf66208a29494dcd94256e5bcee092fR1211 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_html_minifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a merge conflict
5c9fba1
to
03e7ef1
Compare
@kdy1 Fixed |
Description:
Merge the same
style
elements into one:->
The same possible with
script
tags, but need more complex logic and will be implemented in futureRef: kangax/html-minifier#1126
BREAKING CHANGE:
Yes
Related issue (if exists):
No