Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Introduce FastJsWord and FastId in swc_atoms #9826

Merged
merged 17 commits into from
Jan 1, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 1, 2025

Description:

FastJsWord and FastId implement Copy and do not need to be cloned or dropped, unlike JsWord or Id.
Of course, they are inherently unsafe. But I found that I could use it for the minifier.

Related issue:

@kdy1 kdy1 self-assigned this Jan 1, 2025
Copy link

changeset-bot bot commented Jan 1, 2025

🦋 Changeset detected

Latest commit: 1c85f5c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 force-pushed the rspack-fastid branch 2 times, most recently from 211949c to 4438e36 Compare January 1, 2025 00:57
@kdy1 kdy1 added this to the Planned milestone Jan 1, 2025
Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #9826 will not alter performance

Comparing kdy1:rspack-fastid (1c85f5c) with main (f8dff56)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 marked this pull request as ready for review January 1, 2025 02:06
@kdy1 kdy1 requested review from a team as code owners January 1, 2025 02:06
@kdy1 kdy1 enabled auto-merge (squash) January 1, 2025 02:06
@kdy1 kdy1 disabled auto-merge January 1, 2025 02:20
@kdy1 kdy1 merged commit ef0ec38 into swc-project:main Jan 1, 2025
150 of 151 checks passed
@kdy1 kdy1 deleted the rspack-fastid branch January 1, 2025 02:21
@kdy1 kdy1 modified the milestones: Planned, v1.10.6 Jan 7, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant