Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify pandas usage with non-numeric columns #674

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

alee
Copy link
Member

@alee alee commented Mar 5, 2024

pandas now raises errors when computing the mean on a dataframe with non-numeric columns

add a note to the challenge describing the issue and provide a few additional ways of solving it

Thanks to @davidwilby for finding this bug and outlining possible solutions to it in #670

pandas now raises errors when computing the mean on a dataframe with
non-numeric columns

add a note to the challenge describing the issue and provide a few
additional ways of solving it

Thanks to @davidwilby for finding this bug and outlining possible
solutions to it in swcarpentry#670

Co-authored-by: David Wilby <[email protected]>
Co-authored-by: Olav Vahtras <[email protected]>
Copy link

github-actions bot commented Mar 5, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-674

The following changes were observed in the rendered markdown documents:

 14-looping-data-sets.md | 20 ++++++++++++++++----
 md5sum.txt              |  2 +-
 2 files changed, 17 insertions(+), 5 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-05 00:49:55 +0000

github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@alee alee merged commit e2b184e into swcarpentry:main Mar 5, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : e2b184e
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 20:54:39 +0000
Message : Merge pull request #674 from alee/fix_mean_invocation

fix: clarify pandas usage with non-numeric columns
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : b0b89c4
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 20:55:52 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e2b184e
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 20:54:39 +0000
Message : Merge pull request #674 from alee/fix_mean_invocation

fix: clarify pandas usage with non-numeric columns
@alee alee deleted the fix_mean_invocation branch March 5, 2024 20:58
@alee
Copy link
Member Author

alee commented Mar 5, 2024

This was also addressed and fixed by @wgriffa in #666 - apologies for missing that and not crediting you with the fix as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant