-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve formatting of episode 16 solution #681
Conversation
Simulating a dynamical system solution had a new line in the code block which caused the whole block not to be rendered.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-681 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-12 06:05:14 +0000 |
Thanks! I checked the branch out locally and rendered it using the latest sandpaper and it looked good to me, maybe there was an older version of sandpaper @vahtras ? example docker-compose.yml file to be placed in the root directory and can render the site via
|
I tested this locally on macOS by following the instructions here. For reference, I ran I also tested this with @alee's dockerfile and can't see that style error: |
I did an upgrade of sandpaper and the the problem disappeared. Who knows what is was. |
Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Auto-generated via {sandpaper} Source : 031c8c0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 05:32:40 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4837564 Branch : main Author : Olav Vahtras <[email protected]> Time : 2024-06-13 05:31:50 +0000 Message : Merge pull request #681 from danny-lloyd/improve-formatting-ep16 Improve formatting of episode 16 solution
Simulating a dynamical system solution had a new line in the code block which caused the whole block not to be rendered.
URL: https://swcarpentry.github.io/python-novice-gapminder/16-writing-functions.html
Before and after screenshots below:
After: