style sync up/May 15 2021 #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix swcarpentry#526
This is a modification for swcarpentry#501
R-based lessons might take a while to build because packages need to be compiled from source. RStudio Package Manager has compiled versions of packages for ubuntu distros starting with 16.04: https://packagemanager.rstudio.com/client/#/repos/1/overview I've added the necessary magic in the actions yaml to make it work.
This will fix swcarpentry#533
bin/lesson_check.py: allow 'caution' blockquote
Co-authored-by: Zhian N. Kamvar <[email protected]>
Co-authored-by: Zhian N. Kamvar <[email protected]>
Improved relative_root_path
bin/lesson_check.py: one more fix for using_remote_theme()
…sons Template workflow: add two more lessons
Current syncing procedure that used in the Template workflow fails for: 1. Lessons that are, in fact, nsync with the styles repo. 2. For lessons that use The Carpentries' remote theme and have deleted some of the files. This PR makes this step a little bit more intelligent and takes into account the above two scenarios.
Co-authored-by: Zhian N. Kamvar <[email protected]>
Template workflow: smarter syncing with the styles repo
It should've been removed in 7e835fd.
bin/lesson_check.py: allow comments and empty lines in links.md Fixes carpentries/styles#581
bin/lesson_check.py: use proper function
Allow lines that contain a single image or a single link to go over the suggested line length limit.
bin/lesson_check.py: allow exceptions to line length limit Fixes carpentries/styles#591
This change hardens the pattern that matches single-line
image or link:
1. It extends the pattern to be matched in a heading
2. It allows the line to contain {: ...} customizations
3. It allows the line to end with \
lesson_check.py: harden single-line image/link pattern Fixes carpentries/styles#591
This PR allows up to 3 non-word (`\W` in Python's `re`-speak) characters in the beginning and end of the pattern that matches links and images. This is to allow lesson developers place punctuation marks, parentheses, or other symbols before or after the link or image on the same line in Markdown.
lesson_check.py: relax P_LINK_IMAGE_LINE pattern
Don't force hostname into relative_root_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_config.yml: mention Carpentries Incubator.jekyll-metatadabin/lesson_check.py: allow 'language-*' code blocks (allow code blocks with any language- class carpentries/styles#532)bin/lesson_check.py: allow 'caution' blockquote_site.editorconfig: don't trim trailing spaces in markdownlesson.scss: HTML blockbin/util.py: Change ruby executable to "bundle exec ruby"bin/workshop_check.py: update default contact email addresslesson_check.pyallow for missing life_cyclebin/dependencies.R: handle 'no packages were specified' errorlinks.mdin lessons that use remote themelinks.mdrelative_root_pathbin/lesson_check.py: allow comments and empty lines inlinks.mdbin/lesson_check.py: one more fix for using_remote_theme()bin/util.py: remove unused 'IMAGE_FILE_SUFFIX' var (bin/util.py: remove unused 'IMAGE_FILE_SUFFIX' var carpentries/styles#590)bin/lesson_check.py: use proper functionbin/lesson_check.py: allow exceptions to line length limitP_LINK_IMAGE_LINEpatternrelative_root_path_config.yml: sync up with the upstream version