Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammatical typos (#1437) #1440

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fixed grammatical typos (#1437) #1440

merged 1 commit into from
Nov 9, 2023

Conversation

392781
Copy link
Contributor

@392781 392781 commented Nov 8, 2023

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #1437

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Removed the period following "Option 1." and fixed the grammar of "Option 2 is also works" to "Option 2 also works"

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

github-actions bot commented Nov 8, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1440

The following changes were observed in the rendered markdown documents:

 07-find.md | 4 ++--
 md5sum.txt | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-09 06:21:52 +0000

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@bkmgit
Copy link
Contributor

bkmgit commented Nov 9, 2023

@392781 Thanks

@bkmgit bkmgit merged commit 5bf3172 into swcarpentry:main Nov 9, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Auto-generated via {sandpaper}
Source  : 5bf3172
Branch  : main
Author  : Benson Muite <[email protected]>
Time    : 2023-11-09 06:24:56 +0000
Message : Merge pull request #1440 from 392781/main

Fixed grammatical typos (#1437)
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Auto-generated via {sandpaper}
Source  : dbf3517
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-09 06:28:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5bf3172
Branch  : main
Author  : Benson Muite <[email protected]>
Time    : 2023-11-09 06:24:56 +0000
Message : Merge pull request #1440 from 392781/main

Fixed grammatical typos (#1437)
@392781
Copy link
Contributor Author

392781 commented Nov 9, 2023

@bkmgit happy to help 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammar Mistake in "07-find.md" at "Matching and Subtracting" solution.
2 participants