add circleci support; bugfixes #3985
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sweep: PR ReviewAuthor: wwzeng1 Sweep found Sweep has left comments on the pull request for you to review. SummaryThis pull request added CircleCI integration for retrieving and processing logs, alongside various improvements to log handling and messaging clarity. A new environment variable In The Several messaging improvements were made in A new test file Minor changes included the removal of redundant code blocks and the addition of comments for better code clarity. |
![sweep-nightly[bot]](https://avatars.githubusercontent.com/in/324098?s=60&v=4){kind=small}
| @@ -1459,18 +1459,6 @@ def get_files_to_change_for_gha( | |||
| if read_only_snippet.file_path in updated_files: | |||
There was a problem hiding this comment.
The removal of the block of code that reclassified snippets based on the presence of "test" in their file paths could lead to incorrect classification of snippets.
| @@ -28,6 +37,8 @@ def get_files_in_dir(zipfile: zipfile.ZipFile, dir: str): | |||
| if file.startswith(dir) and not file.endswith("/") | |||
| ] | |||
|
|
|||
| def remove_ansi_tags(logs: str) -> str: | |||
There was a problem hiding this comment.
Sweep has identified a redundant function: The new remove_ansi_tags function is useless because its exact functionality is already implemented by the existing strip_ansi_codes function in code_validators.py.
| return response.json() | ||
|
|
||
| # take a commit and return all failing logs as a list | ||
| def get_failing_circleci_logs(circleci_run_url: str): |
There was a problem hiding this comment.
Sweep has identified a redundant function: The new function get_failing_circleci_logs is useless because its functionality is already provided by the existing get_failing_circleci_log_from_url function in on_check_suite.py.
No description provided.