Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support no-cache requests #21

Merged
merged 11 commits into from
Sep 18, 2023
Merged

Feature: Support no-cache requests #21

merged 11 commits into from
Sep 18, 2023

Conversation

swellmike
Copy link
Contributor

Introduces a $nocache request directive that instructs both the client and server to bypass the request cache.

e.g.,

const nProducts = await swell.get('/products/:count', { $nocache: true, price: { $gte: 100 } });

@swellmike swellmike requested a review from a team September 15, 2023 16:19
@swellmike swellmike self-assigned this Sep 15, 2023
@swellmike swellmike merged commit b7dd15c into master Sep 18, 2023
@swellmike swellmike deleted the feature/no-cache-requests branch September 18, 2023 15:56
DimaZhukovsky pushed a commit that referenced this pull request Nov 27, 2023
@swellmike @DimaZhukovsky
Feature: Support no-cache requests (#21)
e2b2a6c 
* code cleanup

* require url

* no mjml

* code cleanup

* fixed tests, rm sinon, ported mocks to jest

* port chai assert -> jest expect

* bump dependencies

* renamed client.server -> client.connection

* prettier code-style

* skip cache is $nocache is specified in requestData
DimaZhukovsky pushed a commit that referenced this pull request Nov 27, 2023
@swellmike @DimaZhukovsky
Feature: Support no-cache requests (#21)
98279ea 
* code cleanup

* require url

* no mjml

* code cleanup

* fixed tests, rm sinon, ported mocks to jest

* port chai assert -> jest expect

* bump dependencies

* renamed client.server -> client.connection

* prettier code-style

* skip cache is $nocache is specified in requestData
DimaZhukovsky pushed a commit that referenced this pull request Nov 27, 2023
@swellmike
Feature: Support no-cache requests (#21)
0a3e67e 
* code cleanup

* require url

* no mjml

* code cleanup

* fixed tests, rm sinon, ported mocks to jest

* port chai assert -> jest expect

* bump dependencies

* renamed client.server -> client.connection

* prettier code-style

* skip cache is $nocache is specified in requestData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianstanescu cristianstanescu cristianstanescu approved these changes

Assignees

@swellmike swellmike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swellmike @cristianstanescu