Support heterogeneous comparison in map utils #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously map utilities were constrained to support only map types with two template parameters (key and value), preventing use of `map_contains()` and friends with things like `std::map` with a custom comparator. This commit generalises the template signatures of the map utilities to support such maps and adds SFINAE detection for `find()` with any arbitrary key type where appropriate, thereby supporting transparent heterogeneous access in `map_contains()` and `map_at_or()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously map utilities were constrained to support only map types with two template parameters (key and value), preventing use of
map_contains()and friends with things likestd::mapwith a custom comparator.This commit generalises the template signatures of the map utilities to support such maps and adds SFINAE detection for
find()with any arbitrary key type where appropriate, thereby supporting transparent heterogeneous access inmap_contains()andmap_at_or().