Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish step to swift-toolbox in CI/CD #1185

Merged
merged 13 commits into from
Sep 15, 2023
Merged

Conversation

pcrumley
Copy link
Contributor

@pcrumley pcrumley commented Sep 13, 2023

This PR adds a command to the Makefile which aids in publishing of the binary tools in console_backend.

@pcrumley pcrumley requested a review from a team September 13, 2023 00:27
Copy link
Contributor

@adrian-kong adrian-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - yea, just a simple release tag
2 - for releases that already exist on package registry, you would probably need to create a external script to fetch all previous gh release and generate based on that.
3 - not too sure about value but no harm in adding all the binaries @silverjam

also should this be done on the private CI side where releases are created (and just add an extra step to build additional binaries and hook to package registry) https://github.com/swift-nav/swift-toolbox-ci/blob/ed55ef50a99e661845a0c9527d9430191831f86a/.github/workflows/distribute.yml#L52

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@silverjam
Copy link
Contributor

also should this be done on the private CI side where releases are created (and just add an extra step to build additional binaries and hook to package registry) https://github.com/swift-nav/swift-toolbox-ci/blob/ed55ef50a99e661845a0c9527d9430191831f86a/.github/workflows/distribute.yml#L52

Doing this in https://github.com/swift-nav/swift-toolbox-ci could work, but it's not necessary since we don't need to use any of the lab machines

@silverjam
Copy link
Contributor

also should this be done on the private CI side where releases are created (and just add an extra step to build additional binaries and hook to package registry) https://github.com/swift-nav/swift-toolbox-ci/blob/ed55ef50a99e661845a0c9527d9430191831f86a/.github/workflows/distribute.yml#L52

Doing this in https://github.com/swift-nav/swift-toolbox-ci could work, but it's not necessary since we don't need to use any of the lab machines

Also, we'd have to introduce new architectures into the matrix there anyway, so I think it's a bit cleaner to just do the Swift Toolbox CLI stuff in it's own CI workflow.

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@pcrumley
Copy link
Contributor Author

I simplified this PR to just contain the makefile changes necessary to make this happen. The CI/CD will live elsewhere.

@pcrumley pcrumley requested a review from a team September 15, 2023 19:32
@pcrumley pcrumley merged commit 9802061 into main Sep 15, 2023
6 checks passed
@pcrumley pcrumley deleted the pcrumley/publish-tools branch September 15, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants