fix 784: dont crash on huge in-memory bodies #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
commented
Nov 22, 2024
| // Also, we must frequently return to the EventLoop because we may get the pause signal | ||
| // from another thread. If we fail to do that promptly, we may balloon our body chunks | ||
| // into memory. | ||
| allDone.futureResult.eventLoop.execute { |
There was a problem hiding this comment.
This is the crucial line (apart from the thread unsafety from UnsafeMutableTransferBox)
weissi
commented
Nov 22, 2024
| @@ -1548,3 +1586,88 @@ private let key = """ | |||
| oYQsPj00S3/GA9WDapwe81Wl2A== | |||
| -----END PRIVATE KEY----- | |||
| """ | |||
|
|
|||
| final class BasicInboundTrafficShapingHandler: ChannelDuplexHandler { | |||
There was a problem hiding this comment.
This turned out to not be necessary, but it's a test-only utility which can't hurt I thought :).
weissi
force-pushed
the
jw-784
branch
2 times, most recently
from
adab7a2 to
692483b
Compare
Lukasa
reviewed
Nov 25, 2024
weissi
force-pushed
the
jw-784
branch
5 times, most recently
from
0afe7d9 to
cd29ba9
Compare
Lukasa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #784
writeChunkshad 3 bugs:UnsafeMutableTransferBox-> removed that type which should never be created