Add Request/Response History to all public Response types

[gregcotten]

Work to close #790

The fact that HTTPClient.Request is not Sendable make me think we're going to need to store something else, such as a URL and HTTPRequestHead, instead?

[Lukasa]

I think HTTPClient.Request can be made Sendable. We haven't bothered yet because we're still working through swift-nio* and don't want to have to revisit older packages, but a targeted change will work.

[Lukasa]

Do we think nil is actually possible here?

[gregcotten]

as mentioned above, but copying here: Not from any HTTPClient.Response vended by the library, but since there are already public initializers, it will be nil for any library users that have been creating their own HTTPClient.Response.

[gregcotten]

I think HTTPClient.Request can be made Sendable. We haven't bothered yet because we're still working through swift-nio* and don't want to have to revisit older packages, but a targeted change will work.

It seems like HTTPClient.Body isn't Sendable. Would adding conformance to it be as simple as marking it Sendable or are its internals more complicated than that?

[Lukasa]

I'd expect that to just work.

[gregcotten]

I'd expect that to just work.

indeed it does!

[Lukasa]

Nice one, I think this looks great.

[Lukasa]

Looks like we need to guard the Foundation imports with #if compiler(>=6.0) and then use @preconcurrency to import them on older compilers.

[gregcotten]

Looks like we need to guard the Foundation imports with #if compiler(>=6.0) and then use @preconcurrency to import them on older compilers.

I did it somewhat surgically - let me know if this works

import Foundation
#if compiler(<6.0)
@preconcurrency import struct Foundation.URL
#endif

[gregcotten]

@Lukasa, I "fixed" the API breakage... I think we should be good to go now

[gregcotten]

Looks like we need to guard the Foundation imports with #if compiler(>=6.0) and then use @preconcurrency to import them on older compilers.

I did it somewhat surgically - let me know if this works

import Foundation
#if compiler(<6.0)
@preconcurrency import struct Foundation.URL
#endif

Nevermind, I don't actually like that and changed it to

#if compiler(>=6.0)
import Foundation
#else
@preconcurrency import Foundation
#endif

[gregcotten]

@Lukasa, ready to go!

[Lukasa]

Great, still happy here, thanks!

[Lukasa]

Looks like the format check has opinions again, I'm afraid.

[Lukasa]

Format check is still grouchy.

[gregcotten]

Format check is still grouchy.

and fixed