Update SDK to Swift 6 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 21, 2024 16:34
Andrea-Scuderi
commented
Dec 24, 2024
| @@ -0,0 +1,231 @@ | |||
| { | |||
There was a problem hiding this comment.
This file needs to be removed once the swift-aws-lambda-runtime gets a versioned
Andrea-Scuderi
commented
Dec 24, 2024
| @@ -39,7 +39,7 @@ playground.xcworkspace | |||
| # Add this line if you want to avoid checking in source code from Swift Package Manager dependencies. | |||
| # Packages/ | |||
| # Package.pins | |||
| Package.resolved | |||
| # Package.resolved | |||
There was a problem hiding this comment.
This needs to be reverted once the swift-aws-lambda-runtime gets a versioned
Andrea-Scuderi
commented
Dec 24, 2024
|
|
||
| import PackageDescription | ||
|
|
||
| #if os(macOS) | ||
| let platforms: [PackageDescription.SupportedPlatform]? = [.macOS(.v15), .iOS(.v13)] |
There was a problem hiding this comment.
iOS is not supported, this need to be removed
Andrea-Scuderi
commented
Dec 24, 2024
| .package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"), | ||
| .package(url: "https://github.com/swift-serverless/swift-sls-adapter", from: "0.2.1"), | ||
| .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.11.2"), | ||
| .package(url: "https://github.com/swift-server/swift-aws-lambda-runtime.git", branch: "main"), |
There was a problem hiding this comment.
This needs to be updated once there is a version for the v2
Andrea-Scuderi
commented
Dec 24, 2024
| var breezeApi: BreezeLambdaHandler<T>? | ||
|
|
||
| func handler(event: APIGatewayV2Request, context: LambdaContext) async throws -> APIGatewayV2Response { | ||
| guard let breezeApi else { throw BreezeLambdaAPIError.invalidHandler } |
There was a problem hiding this comment.
Can we avoid this?
Andrea-Scuderi
commented
Dec 24, 2024
| try await Task.sleep(nanoseconds: 1_000_000_000) | ||
| gracefulShutdownTestTrigger.triggerGracefulShutdown() | ||
| } | ||
| group.cancelAll() |
There was a problem hiding this comment.
Not sure why I need to cancel all the task here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
The PR cannot be merged until a stable version of
swift-aws-lambda-runtimewill be released