[CAS] Improve error message when module cache key is missing #10517
+40
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test llvm |
|
ping |
benlangmuir
reviewed
Apr 30, 2025
When a module cache key is missing, emit better diagnostics that * It is clear it is a cache key missing, so a potential dependency missing, not a CAS error * For other compiler consumers, like a swift compiler that uses a different cache key schema than the clang include tree, it is possible that a detailed cache key cannot be printed. Don't emit extra schema mismatch message that can confuse the users rdar://149707188
cachemeifyoucan
force-pushed
the
eng/PR-149707188
branch
from
1225ae2 to
2371355
Compare
|
@swift-ci please test llvm |
benlangmuir
approved these changes
May 1, 2025
|
Test failures are irrelevant. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module cache key is missing, emit better diagnostics that
rdar://149707188