[lldb] Restore Playground functionality #10946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
The result of an Objective-C expression can be a Swift ValueObject. This means that `po foo` in Objective-C may run a Swift expression to print the object description of the result of the Objective-C expression `foo`. That expression has very few dependencies: ``` Swift._DebuggerSupport.stringForPrintObject(Swift.unsafeBitCast(0x001234, to: AnyObject.self)) ``` To avoid scanning potentially incompatible compiler flags and/or doing implicit imports in anotherwise explicitly built project, this patch ensures that one SwiftASTContext per triple is created, with no other contextual information. This makes `po` in ObjC much faster and reliable, the downside of this is that ```expr -l Swift -- import ModuleName``` will only work reliably for SDK modules outside of Swift frames. rdar://153332037
Playgrounds is setting a breakpoint in the PlaygroundStub executable, which has no debug info and is implemented in C. Before b5a1d34, LLDB would have done an expensive and fragile scan through all images to find any Swift modules and make them available. We stopped doing that because it caused performance and correctness problems in Objective-C code that interacted with Swift. However, avoiding the global scan also breaks Playground's ability to find auxiliary source code. This patch restores the original behavior when SwiftASTContextForExpressions is initialized for a Playground only. rdar://154373965
|
@swift-ci test |
JDevlieghere
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playgrounds is setting a breakpoint in the PlaygroundStub executable,
which has no debug info and is implemented in C. Before
b5a1d34,
LLDB would have done an
expensive and fragile scan through all images to find any Swift
modules and make them available. We stopped doing that because it
caused performance and correctness problems in Objective-C code that
interacted with Swift. However, avoiding the global scan also breaks
Playground's ability to find auxiliary source code.
This patch restores the original behavior when
SwiftASTContextForExpressions is initialized for a Playground only.
rdar://154373965