Disable lld Mach-O tests in the Swift LLVM fork #8511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
approved these changes
Apr 1, 2024
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
al45tair
reviewed
Apr 2, 2024
lld/test/COFF/gc-dwarf-eh.s
Outdated
Comment on lines
3
to
7
| # Swift LLVM fork downstream change start | ||
| # Disable failing test | ||
| # XFAIL: * | ||
| # Swift LLVM fork downstream change end | ||
|
|
There was a problem hiding this comment.
Why are we disabling the gc-dwarf-eh.s test for COFF here? (That isn't anything to do with Mach-O).
|
@swift-ci please test |
|
@swift-ci Please test Windows |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift LLVM fork disabled linking for Darwin in lld, see #8119. To make "ninja check-all" pass, we need to disable running the Mach-O tests.