Simplify implementation of Dispatch-async bridge #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
aciidgh,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
|
@swift-ci test windows |
|
This looks good to me, any noticeable perf impact? |
neonichu
approved these changes
May 5, 2025
jakepetroules
force-pushed
the
eng/PR-simplify-async-io
branch
from
19827c2 to
fee53da
Compare
|
No, but I decided to make some more changes and now it's about 60x faster. |
|
@swift-ci test |
jakepetroules
force-pushed
the
eng/PR-simplify-async-io
branch
from
fee53da to
40a0927
Compare
|
@swift-ci test |
Stress testing this approach over use of a long-lived DispatchIO channel appears to resolve the nondeterministic failures with the file descriptor being destroyed, and is easier to reason about. Closes #21
jakepetroules
force-pushed
the
eng/PR-simplify-async-io
branch
from
40a0927 to
1ec5b30
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stress testing this approach over use of a long-lived DispatchIO channel appears to resolve the nondeterministic failures with the file descriptor being destroyed, and is easier to reason about.
Closes #21