Move extensions/include/cmark-gfm-core-extensions.h cpp includes out of extern "C" block
#81
Conversation
|
@swift-ci please test |
|
#58 did this but seems that it was partial. |
|
CC: @QuietMisdreavus |
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| #include "cmark-gfm-extension_api.h" | ||
| #include "export.h" |
There was a problem hiding this comment.
Should we just move all the header includes out of the extern "C" block? I guess i'm not sure what the precise semantics are that Clang is complaining about, so i'm not sure why this header include is fine while the others are not.
It looks like the module.modulemap file for the base cmark-gfm library doesn't include this header, which is likely why it's not considered a problem. What's stopping us from adding export.h to that module map?
There was a problem hiding this comment.
I just moved the smallest set that the compiler complained about, but I think you're right. I'll try adding export.h to the module map and see what happens, and then move that header outside of the block as well.
When the
extern "C"block is emitted, the compiler complains about these includes.