Make isleap faster #4852
Open
Make isleap faster #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YOCKOW Can we please run the tests? |
|
@swift-ci Please test |
|
@parkera Can we merge CF-only change for perf here? |
|
Tests failed because original |
The assembler generated is better if we compare directly instead of doing fancy ring buffer-eque logic. Proof: https://godbolt.org/z/dferPP9h4
|
@YOCKOW Fixed! Can we try again? |
|
@swift-ci test |
|
I wonder why Linux test has passed because I think new implementation has to be changed as I suggested above🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assembler generated is better if we compare directly instead of doing fancy ring buffer-eque logic.
Proof:
https://godbolt.org/z/dferPP9h4