[Windows] Dynamic fd_set in CFSocket
#4969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `fd_set` on Windows growable by adding additional space to the storing buffer, which effectively extends `fd_set.fd_array` capacity.
lxbndr
force-pushed
the
win-fd-set-dynamic
branch
from
ed13e01 to
d68e344
Compare
|
Rebased on latest |
|
@swift-ci test |
|
Not sure if I am reading CI output correctly, but seems to be unrelated to the changes. |
|
We need to disable the macOS build here, it's not actually supported in SCL-F any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
fd_seton Windows growable by adding additional space to the storing buffer, which effectively extendsfd_set.fd_arraycapacity.With this change fixed
FD_SETSIZE 1024becomes unnecessarily large (every suchfd_settakes more than 8Kb of memory), so it seems reasonable to reduce it to lower value. I guess128will do (which is twice as big as default64).Also, I removed some unused defines left from old bit-field implementation and tossed local vars in
__CFSocketManagerfunction to make them available according to their usage per platform.Follow-up for #4954. Resolves #4958.