Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a thread-safe implementation of Process.currentDirectoryURL #4981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a thread-safe implementation of Process.currentDirectoryURL #4981

wants to merge 1 commit into from

Commits on Sep 15, 2024

  1. Add a thread-safe implementation of Process.currentDirectoryURL 

    posix_spawn_file_actions_addchdir_np is the official way to set the working directory of a spawned process and is supported on both macOS and glibc (Linux, etc.). This makes Process.currentDirectoryURL thread-safe, as the current approach will result in the working directory being nondeterministically assigned when spawning processes across multiple threads, using different working directories.
    @jakepetroules
    jakepetroules committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    84ffdeb View commit details
    Browse the repository at this point in the history