Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #5075

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix various typos #5075

merged 2 commits into from
Nov 6, 2024

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Aug 17, 2024

No description provided.

@Coeur Coeur marked this pull request as draft August 17, 2024 14:22
@Coeur Coeur marked this pull request as ready for review August 17, 2024 14:28
@parkera
Copy link
Contributor

parkera commented Nov 1, 2024

@swift-ci test

@@ -1026,7 +1026,7 @@ extension TestJSONSerialization {
}
}
//test serialize values grater than 1 with maxFractionDigits = 15
func excecute_testSetGraterThanOne() {
func execute_testSetGraterThanOne() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this misses a typo - execute_testSetGreaterThanOne. Same for comment above it.

Copy link
Contributor Author

@Coeur Coeur Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, good catch. Well, next time I do a round of verifications, maybe next year.

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a follow-up comment, but I'm going to merge this and the other one can be done separately.

@parkera parkera merged commit 21b3196 into swiftlang:main Nov 6, 2024
2 checks passed
@Coeur Coeur deleted the coeur/typos branch November 8, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants