Initialize _allBundles in _CFBundleCopyAllBundles before trying to copy it. #5269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py it. The array `_allBundles` is lazily created when the first item is inserted into it in the `_CFBundleAddToTablesLocked` function. There’s a possibility that by the time `_CFBundleCopyAllBundles` is called, `_allBundles` hasn’t been initialized yet. In such cases, lazily initialize `_allBundles`. resolves: rdar://150846072
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
parkera
requested changes
Sep 25, 2025
| } | ||
|
|
||
| bool _CFIsSwift(CFTypeID type, CFSwiftRef obj) { | ||
| if (obj == NULL) { |
There was a problem hiding this comment.
Let's remove this part of the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array
_allBundlesis lazily created when the first item is inserted into it in the_CFBundleAddToTablesLockedfunction. There’s a possibility that by the time_CFBundleCopyAllBundlesis called,_allBundleshasn’t been initialized yet. In such cases, lazily initialize_allBundles.resolves: rdar://150846072