Add navigator-title slot to NavigatorCard + fix small UI spacing details #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mportiz08
approved these changes
Jun 4, 2024
marinaaisa
force-pushed
the
r122909785/navigator-title-slot
branch
from
fb8a334
to
9634f41
Compare
|
@swift-ci test |
mportiz08
reviewed
Jul 31, 2024
| @@ -184,6 +184,10 @@ export default { | |||
| type: Object, | |||
| default: () => ({}), | |||
| }, | |||
| customTag: { | |||
| type: String, | |||
| require: false, | |||
There was a problem hiding this comment.
Suggested change
| require: false, |
Or required: false
| @@ -13,7 +13,7 @@ | |||
| :class="{ expanded, active: isActive, 'is-group': isGroupMarker }" | |||
| :style="{ '--nesting-index': item.depth }" | |||
| :data-nesting-index="item.depth" | |||
| :id="`container-${item.uid}`" | |||
| :id="item.uid ? `container-${item.uid}` : null" | |||
There was a problem hiding this comment.
I think we should keep the uid as a requirement since this id value is important for the underlying dynamic scrolling library that is used for nav items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #122909785, if applicable:
Summary
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded