Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Diagnose invalid characters in bundle identifiers #1012

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Diagnose invalid characters in bundle identifiers #1012

wants to merge 4 commits into from

Commits on Aug 21, 2024

  1. Add bundle identifier validation method to ensure URL host compliance 

    - Implemented `validateBundleIdentifier()` to validate that the bundle identifier only contains characters allowed in URL hosts as per RFC 3986.
- The method checks for invalid characters such as spaces and any characters not included in the alphanumeric, hyphen, period, underscore, and tilde sets.
- If invalid characters are detected, a diagnostic warning is generated and appended to the `problems` array with details about the issue.
- This enhancement helps prevent issues related to incorrect bundle identifiers by enforcing proper formatting standards.
    @agisilaos
    agisilaos committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0a629fa View commit details
    Browse the repository at this point in the history

  2. Add tests for bundle identifier validation 

    - Implement tests for valid and invalid bundle identifiers
- Cover scenarios with spaces and special characters
- Use GIVEN-WHEN-THEN structure for improved readability
- Ensure consistent setup() call across all tests
    @agisilaos
    agisilaos committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f036d4f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary explanation for GIVEN part in test

    @agisilaos
    agisilaos committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8f99c69 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into diagnose-invalid-characters-in-bundle-identi… 

    …fiers
    @agisilaos
    agisilaos authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1b2da4c View commit details
    Browse the repository at this point in the history