Remove spaces from test bundle identifiers #288
Conversation
franklinsch
force-pushed
the
test-bundle-id-spaces
branch
from
3abe563
to
8c1ba0a
Compare
|
@swift-ci please test |
|
Should we add an XCTSkip'd test somewhere that is testing this? So we know if this regresses again in the future? (Unclear to me if having spaces in a bundle ID is supported or not) |
|
That would be testing Foundation behavior here, which I'm not convinced we should do. According to the URL RFC, spaces are disallowed in URL hosts, which is where bundle identifiers are used. |
Maybe we should be transforming bundle IDs that contain spaces then and replacing them with hyphens? Can definitely be a future PR. But since this is allowed behavior currently it seems like we're just hiding future issues by removing these tests entirely. |
|
Given the URL RFC, I think we should actually treat bundle identifiers with spaces as invalid. The bug here is that DocC currently accepts them but shouldn't. I filed #290 |
Removes spaces from the bundle identifiers using in Swift-DocC tests to work around a bug in macOS Ventura (94747378). rdar://94811638
franklinsch
force-pushed
the
test-bundle-id-spaces
branch
from
8c1ba0a
to
3fd32d8
Compare
|
@swift-ci please test |
Bug/issue #, if applicable: rdar://94811638
Summary
Removes spaces from the bundle identifiers using in Swift-DocC tests to work around a bug in macOS Ventura Beta 1 (94747378).
Dependencies
None.
Testing
N/A, not a user facing change.
Checklist
./bin/testscript and it succeeded