Skip to content

[6.2][SwiftScanCAS] Make sure that CAS size limitation can take effect #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Apr 9, 2025

Previously the last CAS instance that was closing the database was not the one that was getting the CAS size limitation setting, resulting in the limit not being in effect.

rdar://148836977
(cherry picked from commit 7134aa1)

Description: CAS size limitation for swift caching cannot take effect due to the last CAS database instance that closes the database is not the one exposed to the build system that gets the size limit.
Origination: N/A
Radar: rdar://148836977
Risk: Low.
Tested: Added unit test
Reviewed by: @cachemeifyoucan

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Apr 9, 2025

@swift-ci Please test

@akyrtzi akyrtzi requested a review from cachemeifyoucan April 9, 2025 17:21
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Apr 11, 2025

@swift-ci Please test

Previously the last CAS instance that was closing the database was not the one
that was getting the CAS size limitation setting, resulting in the limit not being in effect.

rdar://148836977
(cherry picked from commit 7134aa1)
@akyrtzi akyrtzi force-pushed the akyrtzi/pr/6.2-fix-cas-size-limit branch from 847289c to e5bacf8 Compare July 17, 2025 18:03
@akyrtzi akyrtzi requested a review from a team as a code owner July 17, 2025 18:03
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Jul 17, 2025

@swift-ci Please test

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Jul 17, 2025

@swift-ci Please test Windows platform

@akyrtzi akyrtzi merged commit d11ea74 into swiftlang:release/6.2 Jul 18, 2025
3 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/6.2-fix-cas-size-limit branch July 18, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants