[6.2][SwiftScanCAS] Make sure that CAS size limitation can take effect #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 11, 2025
Previously the last CAS instance that was closing the database was not the one that was getting the CAS size limitation setting, resulting in the limit not being in effect. rdar://148836977 (cherry picked from commit 7134aa1)
akyrtzi
force-pushed
the
akyrtzi/pr/6.2-fix-cas-size-limit
branch
from
847289c to
e5bacf8
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the last CAS instance that was closing the database was not the one that was getting the CAS size limitation setting, resulting in the limit not being in effect.
rdar://148836977
(cherry picked from commit 7134aa1)
Description: CAS size limitation for swift caching cannot take effect due to the last CAS database instance that closes the database is not the one exposed to the build system that gets the size limit.
Origination: N/A
Radar: rdar://148836977
Risk: Low.
Tested: Added unit test
Reviewed by: @cachemeifyoucan