SwiftDriverExecution: add explicit dependency on libllbuild #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module directly imports libllbuild, and while the dependency _should_ be available due to the dependency on `llbuildSwift`, this ensures that we do not rely on ordering but rather the explicit dependency is codified into the build graph.
|
@swift-ci please test |
owenv
approved these changes
Jul 10, 2025
artemcm
approved these changes
Jul 10, 2025
`llbuild` is imported always. Simply import that unconditionally.
The value needs to be pushed through the cache as there is no control over the flags for the sub-build and `set` is scoped to the current directory.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
LLDB test hung it seems ... |
|
Please test with following PRs: @swift-ci please test Windows platform |
1 similar comment
|
Please test with following PRs: @swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module directly imports libllbuild, and while the dependency should be available due to the dependency on
llbuildSwift, this ensures that we do not rely on ordering but rather the explicit dependency is codified into the build graph.