[6.1] Ensure that FileManager.copyItem cannot copy directory metadata to files #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmschonfeld
commented
Dec 11, 2024
jmschonfeld
commented
- Explanation: Eliminates a TOCTOU issue that allowed FileManager to copy metadata from files believing they were directories
- Scope: Impacts FileManager.copyItem(atPath:toPath:) on non-Windows platforms
- Original PRs: Ensure that FileManager.copyItem cannot copy directory metadata to files #1081
- Risk: Medium - large amount of new code but it has a decent amount of testing and the reward of fixing the TOCTOU issue is high
- Testing: local testing, swift-ci testing
- Reviewers: @parkera
…les (swiftlang#1081) * (135575520) Ensure that FileManager.copyItem cannot copy directory metadata to files * Fix whitespacing * Fix Windows test failure
jmschonfeld
changed the title
|
@swift-ci please test |
parkera
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.