Forward cherry pick the prebuilts feature to main. #8610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get the prebuilts feature out in time for 6.1, the bulk of the work was done on the release/6.1 branch. Cherry pick those changes to the main branch to get 6.2 caught up. This is a manual cherry pick so it's going to be a bit hard to follow. I did a diff between main and release/6.1 and copied all the changes I made there.
dschaefer2
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
cmcgee1024,
daveyc123,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
jakepetroules
approved these changes
May 2, 2025
This was referenced May 7, 2025
It' not a dependency in the package manifest.
dschaefer2
added a commit
to dschaefer2/swift
that referenced
this pull request
May 9, 2025
Super surprised to see the build for swift test hardcoded in the build.ps1 script instead of in the sourcekit-lsp repo. At any rate, looks like I need to add the dependency on ASN1 here too. This is to support changes in SwiftPM that add the dependency which translates through to sourcekit-lsp. swiftlang/swift-package-manager#8610
|
@swift-ci please test windows |
|
OMG, it finally passed. Now to do this all again for release/6.2... |
dschaefer2
added a commit
to dschaefer2/swift
that referenced
this pull request
May 12, 2025
Super surprised to see the build for swift test hardcoded in the build.ps1 script instead of in the sourcekit-lsp repo. At any rate, looks like I need to add the dependency on ASN1 here too. This is to support changes in SwiftPM that add the dependency which translates through to sourcekit-lsp. swiftlang/swift-package-manager#8610
Catfish-Man
pushed a commit
to swiftlang/swift
that referenced
this pull request
May 15, 2025
Super surprised to see the build for swift test hardcoded in the build.ps1 script instead of in the sourcekit-lsp repo. At any rate, looks like I need to add the dependency on ASN1 here too. This is to support changes in SwiftPM that add the dependency which translates through to sourcekit-lsp. swiftlang/swift-package-manager#8610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the prebuilts feature out in time for 6.1, the bulk of the work was done on the release/6.1 branch. Cherry pick those changes to the main branch to get 6.2 caught up.
This is a manual cherry pick so it's going to be a bit hard to follow. I did a diff between main and release/6.1 and copied all the changes I made there.