Fix swift package describe for packages with binary artifacts that has a .zip extension.
#8809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has a .zip extension.
taji-taji
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
swift package describefor packages with binary artifacts that has a .zip extension.Motivation:
Fixes #4387
I want to avoid an error when running
swift package describeon a package that contains a binary artifact target with a.zipextension.Modifications:
I modified the
Workspace.loadRootPackage(at:observabilityScope:completion)method. Specifically, I updated the logic for local binary targets to also return aBinaryArtifactobject when the file extension is.zip.This change is also based on the comment referenced here.
Result:
When running
swift package describeon a package that contains a binary artifact target with a.zipextension, the package description is now output without throwing an error.