[cxx-interop] Warning unannotated C++ APIs returning SWIFT_SHARED_REF… #76798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| "%0 cannot be annotated with both swift_attr('returns_retained') and swift_attr('returns_unretained') attributes", (const clang::NamedDecl*)) | ||
| ERROR(both_returns_retained_returns_unretained, none, | ||
| "%0 cannot be annotated with both swift_attr('returns_retained') and " | ||
| "swift_attr('returns_unretained') attributes", |
There was a problem hiding this comment.
@fahadnayyar I think we should suggest people to use the macro instead of directly using swift_attr. What are other similar diagnostics doing?
egorzhdan
reviewed
Oct 2, 2024
Comment on lines
+3390
to
+3411
| static bool isForeignReferenceType(const clang::QualType type) { | ||
| if (!type->isPointerType()) | ||
| return false; | ||
|
|
||
| auto pointeeType = | ||
| dyn_cast<clang::RecordType>(type->getPointeeType().getCanonicalType()); | ||
| if (pointeeType == nullptr) | ||
| return false; | ||
|
|
||
| return hasImportAsRefAttr(pointeeType->getDecl()); | ||
| } | ||
|
|
||
| static bool hasImportAsRefAttr(const clang::RecordDecl *decl) { | ||
| return decl->hasAttrs() && llvm::any_of(decl->getAttrs(), [](auto *attr) { | ||
| if (auto swiftAttr = dyn_cast<clang::SwiftAttrAttr>(attr)) | ||
| return swiftAttr->getAttribute() == "import_reference" || | ||
| // TODO: Remove this once libSwift hosttools no longer | ||
| // requires it. | ||
| swiftAttr->getAttribute() == "import_as_ref"; | ||
| return false; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Looks like these functions are copied-and-pasted from elsewhere in ClangImporter. Let's use the existing API instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a warning when C++ APIs (functions or methods) returning C++ foreign reference types or SWIFT_SHARED_REFERENCE types are not annotated with either of SWIFT_RETURNS_RETAINED and SWIFT_RETURNS_UNRETAINED.