[6.2][Concurrency] Hashable funcs should be inlinable for AsyncStream #81127
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
pick-wip-inlinable-for-hashable-asyncstream
branch
from
5442de0 to
5a1e66f
Compare
|
@swift-ci please test |
|
@swift-ci please test |
ktoso
force-pushed
the
pick-wip-inlinable-for-hashable-asyncstream
branch
from
5a1e66f to
1cfef25
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Apr 28, 2025
jamieQ
reviewed
Apr 28, 2025
Comment on lines
+487
to
+489
| @inlinable | ||
| @available(SwiftStdlib 6.2, *) | ||
| @inlinable |
There was a problem hiding this comment.
nit: looks like there are double annotations for some reason – is that intentional?
| @@ -55,6 +55,7 @@ func _unlock(_ ptr: UnsafeRawPointer) | |||
| @available(SwiftStdlib 5.1, *) | |||
| extension AsyncStream { | |||
| @safe | |||
| @usableFromInline | |||
There was a problem hiding this comment.
tangential question regarding this change – i've for some time wondered if the internal storage for these types could in some way be unified into something like _Storage<Element, E: Error> since they have so much duplication. does this change make that idea less feasible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small review followup for #81064
The impls should be @inlinable.
Original PR: #81126
Radar: rdar://149914179