[Concurrency][SE-0471] Change isIsolatingCurrent... to return Bool? #81134
+188
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
DougGregor
and removed request for
compnerd and
rjmccall
This changes the isIsolatingCurrentContext function to return `Bool?` and removes all the witness table trickery we did previously to detect if it was implemented or not. This comes at a cost of trying to invoke it always, before `checkIsolated`, but it makes for an simpler implementation and more checkable even by third party Swift code which may want to ask this question. Along with the `withSerialExecutor` function, this now enables us to check the isolation at runtime when we have an `any Actor` e.g. from `#isolation`. Updates SE-0471 according to https://forums.swift.org/t/se-0471-improved-custom-serialexecutor-isolation-checking-for-concurrency-runtime/78834/ review discussions
ktoso
force-pushed
the
wip-adjust-isIsolatingCurrentContext-impl
branch
from
42a6b9a to
22b20e7
Compare
|
@swift-ci please smoke test |
ktoso
changed the title
ktoso
commented
Apr 28, 2025
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-adjust-isIsolatingCurrentContext-impl
branch
from
552dcf1 to
c779d10
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the isIsolatingCurrentContext function to return
Bool?and removes all the witness table trickery we did previously to detect if it was implemented or not. This comes at a cost of trying to invoke it always, beforecheckIsolated, but it makes for an simpler implementation and more checkable even by third party Swift code which may want to ask this question.Along with the
withSerialExecutorfunction, this now enables us to check the isolation at runtime when we have anany Actore.g. from#isolation.Updates SE-0471 according to
https://forums.swift.org/t/se-0471-improved-custom-serialexecutor-isolation-checking-for-concurrency-runtime/78834/ review discussions