Frontend: Obsolete -fixit-all and -emit-fixits-path
#81280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
force-pushed
the
arachnocampa-luminosa
branch
5 times, most recently
from
0cb7c23 to
d162b62
Compare
xedin
approved these changes
May 5, 2025
|
After a closer look, the fossil record suggests that the majority of these tests are no more than using an alternative means to check fix-its. To make sure we retain test coverage, I’m going to find them a new home and switch them to the diagnostic verifier instead of deleting them. |
AnthonyLatsis
force-pushed
the
arachnocampa-luminosa
branch
from
d162b62 to
bba2146
Compare
|
@swift-ci please smoke test |
With `ARCMigrate` and `arcmt-test` removed from clang in llvm/llvm-project#119269 and the new code migration experience under way (see swiftlang/swift-evolution#2673), these options are no longer relevant nor known to be in use. They were introduced long ago to support fix-it application in Xcode. For now, turn them into a no-op and emit a obsoletion warning.
AnthonyLatsis
force-pushed
the
arachnocampa-luminosa
branch
from
bba2146 to
b0b0cff
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 7, 2025
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 7, 2025
...swiftlang#81280. The deleted test was `test/FixCode/fixits-if-else.swift`. Resurrect it in a better place and switch it to the diagnostic verifier, as it was intended to along with other moved tests in that PR.
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 7, 2025
...swiftlang#81280. The deleted test was `test/FixCode/fixits-if-else.swift`. Resurrect it in a better place and switch it to the diagnostic verifier, as it was intended to along with other moved tests in that PR.
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 7, 2025
…t files after..." ...swiftlang#81280. (cherry picked from commit 3cf3d62)
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 7, 2025
…n..." ...swiftlang#81280. The deleted test was `test/FixCode/fixits-if-else.swift`. Resurrect it in a better place and switch it to the diagnostic verifier, as it was intended to along with other moved tests in that PR. (cherry picked from commit 8928b53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
ARCMigrateandarcmt-testremoved from clang in llvm/llvm-project#119269 and the new code migration experience under way (see swiftlang/swift-evolution#2673), these options are no longer relevant nor known to be in use. They were introduced long ago to support fix-it application in Xcode.For now, turn them into a no-op and emit a obsoletion warning.
Sneaking in that second commit because I found a diagnostic verifier test in
test/FixCodeand couldn’t help it.