fix calls to llvm prefix mapping functions to use space-separated opt… #81792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sina-mahdavi
requested review from
artemcm,
tshortli,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov and
xedin
as code owners
|
Please test with following pull request: @swift-ci Please test |
sina-mahdavi
force-pushed
the
sina-mahdavi/fix-llvm-prefix-mapping-calls
branch
from
ef91ae4 to
e8cf513
Compare
|
Please test with following pull request: @swift-ci Please test |
|
Please test with following pull request: @swift-ci Please smoke test macOS platform |
|
Please test with following pull request: @swift-ci Please smoke test Windows |
cachemeifyoucan
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR changing some of the prefix mapping API's in llvm, some build errors are triggered in swift. I fixed the API usage to prevent those build errors so that the llvm PR can pass CI tests.
PR for cross-repo testing: swiftlang/llvm-project#10751