Add -scanner-prefix-map-paths to the frontend
#82745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sina-mahdavi
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
sina-mahdavi
force-pushed
the
sina-mahdavi/new-scanner-prefix-map-option
branch
from
a831621 to
c5bbdbd
Compare
Do you have anything in mind that I need to write new tests for except modifying the old tests to use the new option instead? I made the old option driver-only and changed all of the old tests using it to use the new format so I think those should already be covering all of the code that has been modified. |
cachemeifyoucan
approved these changes
Jul 11, 2025
| @@ -288,6 +288,7 @@ def main(): | |||
| "-scanner-prefix-map", | |||
| "-scanner-prefix-map-sdk", | |||
| "-scanner-prefix-map-toolchain", | |||
| "-scanner-prefix-map-paths", | |||
There was a problem hiding this comment.
I don't use this script at all but it seems this script doesn't accept multi arg option at all. I don't know if you want to fix this script in the same commit or just leave this out and do the fix in a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current command-line option for specifying prefix mappings for the dependency scanner does not handle paths containing equal signs. This PR adds a new option
-scanner-prefix-map-pathsthat has a multiArg format instead of being=-separated and fixes this issue. The old-scanner-prefix-mapoption is still preserved, but is made driver-only and gets translated to the new option format by the driver.Corresponding PR on Swift-Driver: swiftlang/swift-driver#1949