[NFC][demangling] switch to using NodePrinter::printFunctionName #82767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
adrian-prantl
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 🍒 [demangling] add new methods to the NodePrinter to enable range tracking possibilities when demangling a name #82479 we introduced
NodePrinter::printFunctionName. This method extracts some logic from the demangler into a reusable helper function. The code that was extracted was never replaced by a call to the helper method.This patch replaces it with the call to
printFunctionName.This patch is an NFC.
Very low, this is an NFC
Tested that it compiles against [Syntax Highlighting] Add name and parameters syntax highlighting in Swift backtraces llvm-project#10710 which is the root motivation for this change.