Runtimes: add an initial build of Observation #83006
Conversation
This migrates Observation to the new runtimes build. It requires some additional help during the build to locate the internal `CMakeConfig.h` header from the runtime build. However, this is a good skeleton for us to start addressing some of those issues.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
There was a problem hiding this comment.
I believe we want to copy this like we are doing for Core and Synchronization in Resync.cmake -- unless I'm missing the rational to change approach.
There was a problem hiding this comment.
I'm not convinced that copying the file is the right thing to do - if we cannot isolate it away, I think that we should have the orchestration wire up the internals of the previous build.
There was a problem hiding this comment.
I wonder if @etcwilde has opinions here
|
|
||
| # Configure plist creation for Darwin platforms. | ||
| generate_plist("${CMAKE_PROJECT_NAME}" "${CMAKE_PROJECT_VERSION}" swiftObservation) | ||
| embed_manifest(swiftObservation) |
There was a problem hiding this comment.
Can be done at a later time: we should remember to add another affordance for vendor overrides, e.g.
| embed_manifest(swiftObservation) | |
| embed_manifest(swiftObservation) | |
| include("${${PROJECT_NAME}_VENDOR_MODULE_DIR}/swiftObservation.cmake" OPTIONAL) |
| set_target_properties(swiftObservation PROPERTIES | ||
| Swift_MODULE_NAME Observation) |
There was a problem hiding this comment.
Optional at this stage: we should specify the linker language since we have a C++ source file
| set_target_properties(swiftObservation PROPERTIES | |
| Swift_MODULE_NAME Observation) | |
| set_target_properties(swiftObservation PROPERTIES | |
| Swift_MODULE_NAME Observation | |
| LINKER_LANGUAGE CXX) |
There was a problem hiding this comment.
We don't want to link with the C++ driver, we want to link with the Swift driver. We could be explicit and use the LINKER_LANGUAGE Swift, but I don't think that adds anything of value.
There was a problem hiding this comment.
Selection of the c++ standard library should be driven by a flag in the swift-driver - we need this functionality for the C++ interop anyway. I believe that the current best option is -Xcc -stdlib=... -Xlinker -Xcc -Xlinker -stdlib=... (CC: @artemcm)
| VERSION 6.1.0${BUILD_NUMBER}) | ||
|
|
||
| if(NOT PROJECT_IS_TOP_LEVEL) | ||
| message(SEND_ERROR "Swift Synchronization must build as a standalone project") |
There was a problem hiding this comment.
| message(SEND_ERROR "Swift Synchronization must build as a standalone project") | |
| message(SEND_ERROR "Swift Observation must build as a standalone project") |
There was a problem hiding this comment.
oof ... thanks! Is there a previous thread about the plist.in copying? The thread on this PR is related to CMakeConfig.h generated in the Swift build.
This migrates Observation to the new runtimes build. It requires some additional help during the build to locate the internal
CMakeConfig.hheader from the runtime build. However, this is a good skeleton for us to start addressing some of those issues.