[cxx-interop] Fix assert failure due to invalid location #83032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hit an assert failure do to creating a range where the begin was a valid source location while the end range was an invalid one. Unfortunately, I was not able to create a minimal reproducer but I was able to verify that this fix works because I was able to reproduce this issue while compiling Swift with a patched version of Clang. rdar://155379027
Xazax-hun
requested review from
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
Jul 14, 2025
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an assert failure do to creating a range where the begin was a valid source location while the end range was an invalid one. Unfortunately, I was not able to create a minimal reproducer but I was able to verify that this fix works because I was able to reproduce this issue while compiling Swift with a patched version of Clang.
rdar://155379027