[Sema] Avoid folding sequences multiple times #83034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completion can end up calling into pre-checking multiple times in certain cases, make sure we don't attempt to fold a SequenceExpr multiple times since its original AST is in a broken state post-folding. Instead, just return the already-folded expression. rdar://133717866
hamishknight
requested review from
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
Turns out we can also hit this case for some pattern type-checking cases. I'll fix those in a follow-up and reinstate the assertion.
|
@swift-ci please test |
hamishknight
commented
Jul 14, 2025
| @@ -1,3 +1,3 @@ | |||
| // {"signature":"makeBinOp(swift::ASTContext&, swift::Expr*, swift::Expr*, swift::Expr*, swift::PrecedenceGroupDecl*, bool)"} | |||
| // RUN: not --crash %target-swift-frontend -typecheck %s | |||
| // RUN: not %target-swift-frontend -typecheck %s | |||
There was a problem hiding this comment.
Turns out this also affects pattern type-checking, I'll look into that in a follow-up
hamishknight
changed the title
xedin
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion can end up calling into pre-checking multiple times in certain cases, make sure we don't attempt to fold a SequenceExpr multiple times since its original AST is in a broken state post-folding. Instead, just return the already-folded expression.
rdar://133717866
Resolves #75845