SILGen: Fix an assert when emitting SIL for if #available
#83035
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
jckarter,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
Empty version numbers if availability specs are accepted by Sema prior to Swift 6, and when they occur in `if #available` queries they can make the query AST node invalid without aborting compilation. Adjust an assertion in SILGen to compensate.
tshortli
force-pushed
the
silgen-if-available-assert
branch
from
a2d47d1 to
fbe686d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty version numbers in availability specs are accepted by Sema prior to Swift 6, and when they occur in
if #availablequeries they can make the query AST node invalid without aborting compilation. Adjust an assertion in SILGen to compensate.