ConstraintSystem: Make key paths for properties with unavailable setters read-only #83054
+186
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…ers read-only. Previously, only conditional unavailability was considered, but setters that are always unavailable must also make a keypath read-only. Resolves rdar://155832511.
xedin
approved these changes
Jul 15, 2025
…renced. In implicit contexts that are universally unavailable, allow writable key paths to be formed to properties with setters that are also marked as universally unavailable. This fixes a regression from the previous commit where the code synthesized for `@Observable` properties in universally unavailable classes was rejected by the availability checker.
tshortli
force-pushed
the
unavailable-setters-require-read-only-key-paths
branch
from
ce3ac35 to
99380bf
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only conditional unavailability was considered, but setters that are always unavailable must also make a keypath read-only.
Resolves rdar://155832511.