[6.2][SILOptimizer]: fix some missing use after consume diagnostics #83525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates ConsumeOperatorCopyableValuesChecker to identify store_borrow
instructions as a liveness-affecting use so that patterns that would
previously slip through undiagnosed are correctly identified. e.g.
```swift
func use<V>(_ v: borrowing V) {}
func f() {
let a = A()
_ = consume a
use(a) // previously would not be diagnosed
}
```
(cherry picked from commit 754a300)
|
@swift-ci please smoke test |
|
@nate-chandler could you please let me know your assessment of the 'risk' of this change (and feel free to just edit the description if that's possible)? |
|
@jamieQ certainly! This is a low risk change. It only affects consume checking of copyable values. It only increases the strictness of that checking, so it shouldn't cause any previously diagnosed code to go undiagnosed. |
|
@DougGregor FYI as release manager |
|
@swift-ci please test linux platform |
|
@swift-ci please test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Updates
ConsumeOperatorCopyableValuesCheckerto identifystore_borrowinstructions as a liveness-affecting use so that patterns that would previously slip through undiagnosed are correctly identifiedScope:
Issues:
Original PRs:
Risk:
Testing:
Reviewers: