Fix some major SILGen bugs with pack handling: #83555
Merged
+297
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
approved these changes
Aug 6, 2025
- Calls to variadic-generic protocol requirements weren't applying substitutions properly, so expansion-sensitive types in the callee signature weren't pairing properly with their expansions in the caller. - emitPackTransform had an over-destroy if the transformation function actually emitted into the temporary element directly. - There were some MV ownership assertions that were wrong, which revealed that the corresponding code really didn't handle consuming/ borrowing mismatches properly at all. - We were completely mishandled consuming packs. Fixes swiftlang#81002, swiftlang#80995, and swiftlang#81600.
rjmccall
force-pushed
the
variadic-witness-fixes
branch
from
c3d7684 to
8ad4aae
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please clean smoke test macOS |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
1 similar comment
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to variadic-generic protocol requirements weren't applying substitutions properly, so expansion-sensitive types in the callee signature weren't pairing properly with their expansions in the caller.
emitPackTransform had an over-destroy if the transformation function actually emitted into the temporary element directly.
There were some MV ownership assertions that were wrong, which revealed that the corresponding code really didn't handle consuming/ borrowing mismatches properly at all.
We were completely mishandled consuming packs.
Fixes #81002, fixes #80995, fixes #81600.