[IDE] Use LookUpConformanceInModule for synthesized extension requirement substitution #83565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rement substitution The extension may have requirements stating new conformance requirements that aren't present in the underlying substitution map for the conforming type. rdar://152164768
An extension decl is its own inner DeclContext.
And check `is-><ProtocolType>` instead of `isExistentialType`. Should be NFC.
This is unnecessary since the local conformances for a protocol can only contain self-conformances, which we don't want to visit anyway. This can just be a straightforward loop over the local conformances.
We only care about the case where we're substituting into a protocol extension, otherwise the substitution map is an identity map.
Get the substitution map from the conformance rather than building it from the base type.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension may have requirements stating new conformance requirements that aren't present in the underlying substitution map for the conforming type.
rdar://152164768