Demangling: correct build for the runtime #83576
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
reviewed
Aug 6, 2025
This is required to ensure that we do not get ODR violations due to LLVMSupport being linked in with multiple definitions. We would previously miscompile the library resulting in a mixed signature containing both `__swift::runtime::llvm::` and `::llvm::` versions of `StringRef`.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
edymtt
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up some whitespace in the CMakeLists.txt to match the rest of the build system. Most importantly, define
SWIFT_RUNTIMEto avoid ODR violations in the runtime build.