-
Notifications
You must be signed in to change notification settings - Fork 72
Changes for release process #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Eventually will be used downstream to tag releases Also setup PR job to package the VSIX and run tests against it so we can test against that in verifier jobs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one extremely minor comment.
. .github/workflows/scripts/setup-linux.sh | ||
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
npm ci | ||
npm run compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This compile step is not necessary: npm run package
already does a compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix
Allow renaming the prerelease VSIX
Archive the commit SHA used to package the VSIX