Skip to content

Changes for release process #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

Conversation

award999
Copy link
Contributor

@award999 award999 commented May 2, 2025

Allow renaming the prerelease VSIX

  • Since pre-release is always 1 minor version higher, we know it's the second binary

Archive the commit SHA used to package the VSIX

  • Eventually will be used downstream to tag releases
  • Also setup PR job to package the VSIX and run tests against it so we can test against that in verifier jobs as well

award999 added 5 commits May 2, 2025 11:54
Eventually will be used downstream to tag releases
Also setup PR job to package the VSIX and run tests against it so we can
test against that in verifier jobs as well
@award999 award999 marked this pull request as ready for review May 6, 2025 13:45
@award999 award999 requested review from adam-fowler and 0xTim as code owners May 6, 2025 13:45
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one extremely minor comment.

. .github/workflows/scripts/setup-linux.sh
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
npm ci
npm run compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compile step is not necessary: npm run package already does a compile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

@award999 award999 merged commit 576a7c7 into swiftlang:main May 6, 2025
18 checks passed
@award999 award999 deleted the release-script branch May 6, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants