Merge pull request #35 from keithws/remove-hashchange-library-dependency

Remove hashchange library dependency
swiftype · Feb 13, 2019 · 09fefe3 · 09fefe3
2 parents 539718a + 5ff3f34
commit 09fefe3
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -23,15 +23,13 @@ Requirements:
 Include the following in the header of your webpage:
 
 * the latest version of jQuery
-* the [hashchange](https://github.com/cowboy/jquery-hashchange) jQuery plugin (version included)
 * the Swiftype Search jQuery plugin
 * (optional) the Swiftype Search stylesheet
 
 All together it should look like this:
 
 ```html
 <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
-<script type="text/javascript" src="jquery.ba-hashchange.min.js"></script>
 <script type="text/javascript" src="jquery.swiftype.search.js"></script>
 <link type="text/css" rel="stylesheet" href="search.css" media="all" />
 ```

diff --git a/bower.json b/bower.json
@@ -20,7 +20,6 @@
     "tests"
   ],
   "dependencies": {
-    "jquery": ">=1.11.1",
-    "jquery-hashchange": "latest"
+    "jquery": ">=1.11.1"
   }
 }
diff --git a/custom.html b/custom.html
@@ -10,7 +10,6 @@
     </style>
     <script type='text/javascript' src="http://twitter.github.com/hogan.js/builds/3.0.1/hogan-3.0.1.js"></script>
     <script type='text/javascript' src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
-    <script type='text/javascript' src='jquery.ba-hashchange.min.js'></script>
     <script type='text/javascript' src='jquery.swiftype.search.js'></script>
     <link type='text/css' rel='stylesheet' href='search.css' media='all' />
     <script type='text/javascript'>

diff --git a/jquery.ba-hashchange.min.js b/jquery.ba-hashchange.min.js
diff --git a/jquery.swiftype.search.js b/jquery.swiftype.search.js
@@ -128,7 +128,7 @@
           });
         };
 
-      $(window).hashchange(function () {
+      function handleHashchange () {
         var params = $.hashParams();
         if (params.stq) {
           submitSearch(params.stq, {
@@ -141,7 +141,9 @@
             $contentCache.remove();
           }
         }
-      });
+      }
+
+      $(window).on("hashchange", handleHashchange);
 
       var $containingForm = $this.parents('form');
       if ($containingForm) {
@@ -184,7 +186,7 @@
         };
       };
 
-      $(window).hashchange(); // if the swiftype query hash is present onload (maybe the user is pressing the back button), submit a query onload
+      handleHashchange(); // if the swiftype query hash is present onload (maybe the user is pressing the back button), submit a query onload
     });
   };
 

diff --git a/multiple_types.html b/multiple_types.html
@@ -3,7 +3,6 @@
     <head>
         <script type='text/javascript' src="http://twitter.github.com/hogan.js/builds/3.0.1/hogan-3.0.1.js"></script>
         <script type='text/javascript' src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
-        <script type='text/javascript' src='jquery.ba-hashchange.min.js'></script>
         <script type='text/javascript' src='jquery.swiftype.search.js'></script>
         <link type='text/css' rel='stylesheet' href='search.css' media='all' />
         <script type='text/javascript'>

diff --git a/standard.html b/standard.html
@@ -2,7 +2,6 @@
 <html>
   <head>
     <script type='text/javascript' src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
-    <script type='text/javascript' src='jquery.ba-hashchange.min.js'></script>
     <script type='text/javascript' src='jquery.swiftype.search.js'></script>
     <link type='text/css' rel='stylesheet' href='search.css' media='all' />
     <script type='text/javascript'>