Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/improve wormhole token scraper #440

Merged
merged 6 commits into from
Oct 14, 2022
Merged

UI/improve wormhole token scraper #440

merged 6 commits into from
Oct 14, 2022

Conversation

wormat
Copy link
Collaborator

@wormat wormat commented Oct 14, 2022 •
edited
Loading

Completes the first three to-dos in #439 and fixes lint issues.

Notion ticket: https://www.notion.so/exsphere/Bring-back-Wormhole-form-bd96882511604d06a09d79476ba35c7f

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@wormat wormat added the improvement Improving an existing feature label Oct 14, 2022
swimthor
swimthor reviewed Oct 14, 2022
View reviewed changes
apps/ui/package.json Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa1bbdd
Status: ✅  Deploy successful!
Preview URL: https://e28b3e3e.swim-ui.pages.dev
Branch Preview URL: https://ui-improve-wormhole-token-sc.swim-ui.pages.dev

View logs

@wormat wormat force-pushed the ui/improve-wormhole-token-scraper branch from 33b7bb3 to fa1bbdd Compare October 14, 2022 15:59
@wormat wormat requested a review from swimthor October 14, 2022 16:28
@wormat wormat merged commit 2aad414 into ui/wormhole-hooks Oct 14, 2022
@wormat wormat deleted the ui/improve-wormhole-token-scraper branch October 14, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyphertrace cyphertrace Awaiting requested review from cyphertrace

@swimthor swimthor Awaiting requested review from swimthor

Assignees
No one assigned
Labels
improvement Improving an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wormat @swimthor